Improve rendering performance of search results #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendan-kellam
force-pushed
the
bkellam/filtering
branch
from
42ceea2 to
a8a8bc3
Compare
brendan-kellam
force-pushed
the
bkellam/virtual_scrolling
branch
from
67a3413 to
a5e0fcf
Compare
brendan-kellam
force-pushed
the
bkellam/virtual_scrolling
branch
from
a5e0fcf to
3f231b3
Compare
brendan-kellam
changed the title
brendan-kellam
force-pushed
the
bkellam/virtual_scrolling
branch
from
c318353 to
719448f
Compare
msukkari
previously approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the perf of the search result list, resulting in a ~10x speedup for search results to render. This is achieved using react-virtual, which allows us to only render the portion of the list that is visible (plus some buffer).